----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1308/#review3090 -----------------------------------------------------------
I would like to avoid the creation of 'LegacyTopology' class. If there is something that only current topologies require / lack, we should fix that something in the individual topologies themselves or for all the topologies in the BaseTopology class. - Nilay Vaish On July 14, 2012, 9:03 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1308/ > ----------------------------------------------------------- > > (Updated July 14, 2012, 9:03 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9123:f8cb414bcd64 > --------------------------- > Ruby: Clean up topology changes > Moved instantiateTopology into Ruby.py and removed the topologies directory > I'm not completely sure why the topology creation was in the src/ directory, > but I think it was because previously the python needed to be compiled. > > Also added some extra inheritance to the topologies to clean up some issues > in the legacy topologies > > > Diffs > ----- > > configs/ruby/Ruby.py 48eeef8a0997 > configs/topologies/BaseTopology.py 48eeef8a0997 > configs/topologies/Crossbar.py 48eeef8a0997 > configs/topologies/Mesh.py 48eeef8a0997 > configs/topologies/MeshDirCorners.py 48eeef8a0997 > configs/topologies/Pt2Pt.py 48eeef8a0997 > configs/topologies/Torus.py 48eeef8a0997 > src/mem/ruby/network/topologies/SConscript 48eeef8a0997 > src/mem/ruby/network/topologies/TopologyCreator.py 48eeef8a0997 > > Diff: http://reviews.gem5.org/r/1308/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
