----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1383/#review3369 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Aug. 31, 2012, 4:21 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1383/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 4:21 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9182:f5f184f18e42 > --------------------------- > Base CPU: Initialize profileEvent to NULL > > The profileEvent pointer is tested against NULL in various places, but > it is not initialized unless running in full-system mode. In SE mode, this > can result in segmentation faults when profileEvent default intializes to > something other than NULL. > > > Diffs > ----- > > src/cpu/base.cc 42807286d6cb > > Diff: http://reviews.gem5.org/r/1383/diff/ > > > Testing > ------- > > Tested with se.py, collecting and restoring from checkpoints > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
