----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1385/#review3371 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Aug. 31, 2012, 4:43 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1385/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 4:43 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9184:2306d524ec1c > --------------------------- > Standard Switch: Drain the system before switching CPUs > > When switching from an atomic CPU to any of the timing CPUs, a drain is > unnecessary since no events are scheduled in atomic mode. However, when > trying to switch CPUs starting with a timing CPU, there may be events > scheduled. This change ensures that all events are drained from the system > by calling m5.drain before switching CPUs. > > > Diffs > ----- > > configs/common/Simulation.py 42807286d6cb > src/python/m5/simulate.py 42807286d6cb > > Diff: http://reviews.gem5.org/r/1385/diff/ > > > Testing > ------- > > Since m5.changeToTiming() is used by any atomic CPU -> timing CPU switch, > tested all combinations of switches with x86. All prior working combinations > still work correctly, and this patch enables timing -> detailed switch as > necessary for Ruby. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
