----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1377/#review3455 -----------------------------------------------------------
Ship it! It seems like you are maintaining the same basic functionality, so I don't have any real problems with it. Just more code we'll have to rebase to. :) - Brad Beckmann On Sept. 3, 2012, 9:13 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1377/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2012, 9:13 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9182:de31aeefa3f5 > --------------------------- > AddrRange: Simplify AddrRange params Python hierarchy > > This patch simplifies the Range object hierarchy in preparation for an > address range class that also allows striping (e.g. selecting a few > bits as matching in addition to the range). > > To extend the AddrRange class to an AddrRegion, the first step is to > simplify the hierarchy such that we can make it as lean as possible > before adding the new functionality. The only class using Range and > MetaRange is AddrRange, and the three classes are now collapsed into > one. > > > Diffs > ----- > > configs/common/FSConfig.py 42807286d6cb > configs/ruby/MESI_CMP_directory.py 42807286d6cb > configs/ruby/MI_example.py 42807286d6cb > configs/ruby/MOESI_CMP_directory.py 42807286d6cb > configs/ruby/MOESI_CMP_token.py 42807286d6cb > configs/ruby/MOESI_hammer.py 42807286d6cb > configs/ruby/Network_test.py 42807286d6cb > configs/ruby/Ruby.py 42807286d6cb > src/python/m5/params.py 42807286d6cb > > Diff: http://reviews.gem5.org/r/1377/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
