----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1415/#review3491 -----------------------------------------------------------
Ship it! looks fine to me. Probably some work on making sure checkpoints still work is required. - Ali Saidi On Sept. 11, 2012, 11:22 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1415/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 11:22 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9219:6e9835b45bb7 > --------------------------- > Mem: Separate the host and guest views of memory backing store > > This patch moves all the memory backing store operations from the > independent memory controllers to the global physical memory. The main > reason for this patch is to allow address striping in a future set of > patches, but at this point it already provides some useful > functionality in that it is now possible to change the number of > memory controllers and their address mapping in combination with > checkpointing. Thus, the host and guest view of the memory backing > store are now completely separate. > > With this patch, the individual memory controllers are far simpler as > all responsibility for serializing/unserializing is moved to the > physical memory. Currently, the functionality is more or less moved > from AbstractMemory to PhysicalMemory without any major > changes. However, in a future patch the physical memory will also > resolve any ranges that are interleaved and properly assign the > backing store to the memory controllers, and keep the host memory as a > single contigous chunk per address range. > > Functionality for future extensions which involve CPU virtualization > also enable the host to get pointers to the backing store. > > > Diffs > ----- > > src/mem/abstract_mem.hh ee27d0bf7353 > src/mem/abstract_mem.cc ee27d0bf7353 > src/mem/physical.hh ee27d0bf7353 > src/mem/physical.cc ee27d0bf7353 > src/sim/system.cc ee27d0bf7353 > > Diff: http://reviews.gem5.org/r/1415/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
