> On Sept. 20, 2012, 12:42 p.m., Ali Saidi wrote: > > src/base/output.cc, line 89 > > <http://reviews.gem5.org/r/1427/diff/1/?file=29795#file29795line89> > > > > we probably should do this, but do you know where we're trying to open > > the same file twice? > > > > In that case it probably should happen outside of the if block because > > a .gz file could have the same issue > >
Yes, we're trying to open the ruby.stats file twice due to the "Stats::getDumpQueue().process();" in src/base/stats/text.cc:151 that I added in the patch, see below. I'm updating the patch without these three lines. If anybody things we should do the check for any file (.gz or not) we can add these three lines again at the beginning of the method, outside the if block, just as Ali suggests. > On Sept. 20, 2012, 12:42 p.m., Ali Saidi wrote: > > src/base/stats/text.cc, line 151 > > <http://reviews.gem5.org/r/1427/diff/1/?file=29798#file29798line151> > > > > is this going to happen twice now? once here and one by the python > > that got us here? > > You're right, the stats are dumped twice now. This is why in src/base/output.cc:89-91 it was needed to check that the file was not already opened. I'm updating the patch removing this line so that it only happens once, in the python path. - Lluc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1427/#review3501 ----------------------------------------------------------- On Sept. 21, 2012, 7:45 a.m., Lluc Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1427/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 7:45 a.m.) > > > Review request for Default. > > > Description > ------- > > This patch resets/dumps ruby stats when m5 stats are reset/dumped. > > This patch is basically an update of review request #1202, that for some > reason couldn't be applied. This one should work. > > > Diffs > ----- > > src/python/swig/stats.i 9fa13250abd8 > src/mem/ruby/profiler/Profiler.cc 9fa13250abd8 > src/base/statistics.cc 9fa13250abd8 > src/base/statistics.hh 9fa13250abd8 > src/mem/ruby/system/System.cc 9fa13250abd8 > src/mem/ruby/system/System.hh 9fa13250abd8 > > Diff: http://reviews.gem5.org/r/1427/diff/ > > > Testing > ------- > > > Thanks, > > Lluc Alvarez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
