----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1431/#review3508 -----------------------------------------------------------
Ship it! Seems fine. - Nilay Vaish On Sept. 21, 2012, 9:04 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1431/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 9:04 a.m.) > > > Review request for Default. > > > Description > ------- > > This patch moves the block size computation from findBlockSize to > initialisation time, once all the neighbouring ports are connected. > > There is no need to dynamically update the block size, and the caching > of the value effectively avoided that anyhow. This is very similar to > what was already in place, just with a slightly leaner implementation. > > > Diffs > ----- > > src/mem/bus.hh 7d506c3ef13d > src/mem/bus.cc 7d506c3ef13d > src/mem/coherent_bus.hh 7d506c3ef13d > src/mem/coherent_bus.cc 7d506c3ef13d > src/mem/noncoherent_bus.hh 7d506c3ef13d > > Diff: http://reviews.gem5.org/r/1431/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
