On Fri, 12 Oct 2012, Ali Saidi wrote:
On Sept. 21, 2012, 9:17 a.m., Nilay Vaish wrote:
src/base/addr_range.hh, line 134
<http://reviews.gem5.org/r/1429/diff/1/?file=29812#file29812line134>
Why do we need to do this? How many characters are we saving any way?
Andreas Hansson wrote:
The operators are important with the addition of striping. The whole idea
is to hide all the checking for interleaving and matching inside the AddrRange
and never use the start and end outside of this class. I hope that explains it.
Nilay Vaish wrote:
Andreas, I wrote to you almost three weeks back that I do not like
overloading the
equality operator for checking whether the address lies in a range. Can you
not just
create a new function?
Andreas Hansson wrote:
Sure, I'm happy to do either. The equality operator is only there for
historical reasons, that is how it has been done up till this very point.
Rather than changing all the places where it is used (and it is quite a few) I
was happy to know if anyone else sees a need to change it before going and
doing so.
Andreas Hansson wrote:
In addition, if we decide to change it, I want to keep it out of this
patch. I hope that's ok.
Nilay Vaish wrote:
I am fine with having a separate patch for the change.
Personally, I'm fine with using the operator overloading here. What problem do
you have with it specifically?
The operation being carried out is not an equality check.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
