-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1475/#review3597
-----------------------------------------------------------


Any ideas, feedback? Good to go?

- Andreas Hansson


On Oct. 20, 2012, 8:46 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1475/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 8:46 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> Changeset 9308:0c8aa2de4649
> ---------------------------
> config: Use SimpleDRAM in full-system, and with o3 and inorder
> 
> This patch favours using SimpleDRAM with the default timing instead of
> SimpleMemory for all regressions that involve the o3 or inorder CPU,
> or are full system (in other words, where the actual performance of
> the memory is important for the overall performance).
> 
> Moving forward, the solution for FSConfig and the users of fs.py and
> se.py is probably something similar to what we use to choose the CPU
> type. I envision a few pre-set configurations SimpleLPDDR2,
> SimpleDDR3, etc that can be choosen by a dram_type option. Feedback on
> this part is welcome.
> 
> This patch changes plenty stats and adds all the DRAM controller
> related stats. A follow-on patch updates the relevant statistics. The
> total run-time for the entire regression goes up with ~5% with this
> patch due to the added complexity of the SimpleDRAM model. This is a
> concious trade-off to ensure that the model is properly tested.
> 
> 
> Diffs
> -----
> 
>   configs/common/FSConfig.py ac608464be80 
>   tests/configs/inorder-timing.py ac608464be80 
>   tests/configs/o3-timing-checker.py ac608464be80 
>   tests/configs/o3-timing-mp.py ac608464be80 
>   tests/configs/o3-timing.py ac608464be80 
> 
> Diff: http://reviews.gem5.org/r/1475/diff/
> 
> 
> Testing
> -------
> 
> util/regress all passing (disregarding t1000 and eio)
> 
> stats update will follow
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to