Hi Mitch, Thanks for flagging this. Will bump the se script. Let me know if there are other issues.
Andreas On 26/10/2012 00:39, "Mitch Hayenga" <[email protected]> wrote: >This actually breaks the SE python script (when used with caches). This >is >just because of the name change from L1Cache to L1. > > >command line: ./build/ARM/gem5.opt configs/example/se.py --caches >--cmd=../tests/test1 >Traceback (most recent call last): > File "<string>", line 1, in <module> > File "/home/hayenga/Documents/sim/gem5/src/python/m5/main.py", line 359, >in main > exec filecode in scope > File "configs/example/se.py", line 209, in <module> > CacheConfig.config_cache(options, system) > File "/home/hayenga/Documents/sim/gem5/configs/common/CacheConfig.py", >line 68, in config_cache > icache = L1Cache(size = options.l1i_size, >NameError: global name 'L1Cache' is not defined > > > >On Thu, Oct 25, 2012 at 1:32 AM, Andreas Hansson ><[email protected]>wrote: > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/1481/#review3596 >> ----------------------------------------------------------- >> >> >> >> configs/common/Caches.py >> <http://reviews.gem5.org/r/1481/#comment3605> >> >> Indeed...92! This is what all the affected regressions used until >>this >> point. At least now we can change it in a single location, and also >>unify >> this with the remaining three regressions that are slightly less >>aggressive >> on this front. Next patch :) >> >> >> - Andreas Hansson >> >> >> On Oct. 24, 2012, 7:14 a.m., Andreas Hansson wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > http://reviews.gem5.org/r/1481/ >> > ----------------------------------------------------------- >> > >> > (Updated Oct. 24, 2012, 7:14 a.m.) >> > >> > >> > Review request for Default. >> > >> > >> > Description >> > ------- >> > >> > Changeset 9314:f63537293334 >> > --------------------------- >> > config: Use shared cache config for regressions >> > >> > This patch uses the common L1, L2 and IOCache configuration for the >> > regressions that all share the same cache parameters. There are a few >> > regressions that use a slightly different configuration (memtest, >> > o3-timing=mp, simple-atomic-mp and simple-timing-mp), and the latter >> > are not changed in this patch. They will be updated in a future patch. >> > >> > The common cache configurations are changed to match the ones used in >> > the regressions, and are slightly changed with respect to what they >> > were. Hopefully this means we can converge on a common base >> > configuration, used both in the normal user configurations and >> > regressions. >> > >> > As only regressions that shared the same cache configuration are >> > updated, no regressions are affected. >> > >> > >> > Diffs >> > ----- >> > >> > configs/common/Caches.py f634a34f2f0b >> > tests/configs/o3-timing-mp.py f634a34f2f0b >> > tests/configs/pc-o3-timing.py f634a34f2f0b >> > tests/configs/pc-simple-atomic.py f634a34f2f0b >> > tests/configs/pc-simple-timing.py f634a34f2f0b >> > tests/configs/realview-o3-checker.py f634a34f2f0b >> > tests/configs/realview-o3-dual.py f634a34f2f0b >> > tests/configs/realview-o3.py f634a34f2f0b >> > tests/configs/realview-simple-atomic-dual.py f634a34f2f0b >> > tests/configs/realview-simple-atomic.py f634a34f2f0b >> > tests/configs/realview-simple-timing-dual.py f634a34f2f0b >> > tests/configs/realview-simple-timing.py f634a34f2f0b >> > tests/configs/tsunami-inorder.py f634a34f2f0b >> > tests/configs/tsunami-o3-dual.py f634a34f2f0b >> > tests/configs/tsunami-o3.py f634a34f2f0b >> > tests/configs/tsunami-simple-atomic-dual.py f634a34f2f0b >> > tests/configs/tsunami-simple-atomic.py f634a34f2f0b >> > tests/configs/tsunami-simple-timing-dual.py f634a34f2f0b >> > tests/configs/tsunami-simple-timing.py f634a34f2f0b >> > >> > Diff: http://reviews.gem5.org/r/1481/diff/ >> > >> > >> > Testing >> > ------- >> > >> > util/regress all passing (disregarding t1000 and eio) >> > >> > >> > Thanks, >> > >> > Andreas Hansson >> > >> > >> >> _______________________________________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/gem5-dev >> >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
