----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1530/#review3690 -----------------------------------------------------------
What exactly is the point of this? For those that know how signals work, this is just unnecessary confusion. If you want to centralize all signal handlers, then move them. - Nathan Binkert On Nov. 2, 2012, 10:17 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1530/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2012, 10:17 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9355:adc19edfa256 > --------------------------- > base: Create a central header listing all signals used within gem5 > > There is currently no central place where all signals used within gem5 > are listed. This patch adds a header file and with a name space > containing constants for all signals used within gem5. This simplifies > the task of finding a non-conflicting signal when implementing new > functionality that requires signals. > > > Diffs > ----- > > src/base/pollevent.cc 844f9e724343 > src/base/signal.hh PRE-CREATION > src/sim/init.cc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1530/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
