----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1556/#review3722 -----------------------------------------------------------
Ship it! I think, in near term, this will be a source of trouble for users. - Nilay Vaish On Dec. 6, 2012, 11:58 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1556/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 11:58 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9389:4233bdc81103 > --------------------------- > scons: Enforce gcc >= 4.4 or clang >= 2.9 and c++0x support > > This patch checks that the compiler in use is either gcc >= 4.4 or > clang >= 2.9. and enables building with --std=c++0x in all cases. As a > consequence, we can tidy up the hashmap and always have static_assert > available. If anyone wants to use alternative compilers, icc for > example supports c++0x to a similar level and could be added if > needed. > > This patch opens up for a more elaborate use of c++0x features that > are present in gcc 4.4 and clang 2.9, e.g. auto typed variables, > variadic templates, rvalues and move semantics, and strongly typed > enums. There will be no going back on this one... > > > Diffs > ----- > > SConstruct 844f9e724343 > ext/libelf/SConscript 844f9e724343 > src/base/compiler.hh 844f9e724343 > src/base/hashmap.hh 844f9e724343 > src/base/stats/text.cc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1556/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
