> On Dec. 18, 2012, 4:12 p.m., Nilay Vaish wrote: > > src/mem/addr_mapper.cc, line 269 > > <http://reviews.gem5.org/r/1580/diff/1/?file=32776#file32776line269> > > > > Why make a copy and not directly return originalRanges?
vector vs list - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1580/#review3760 ----------------------------------------------------------- On Dec. 6, 2012, 8:22 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1580/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 8:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9376:46bc30121f6b > --------------------------- > mem: Skip address mapper range checks to allow more flexibility > > This patch makes the address mapper less stringent about checking the > before and after ranges, i.e. the original and remapped ranges. The > checks were not really necessary, and there are situations when the > previous checks were too strict. > > > Diffs > ----- > > src/mem/addr_mapper.cc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1580/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
