> On Jan. 4, 2013, 1:41 a.m., Andreas Hansson wrote:
> > configs/ruby/Ruby.py, line 102
> > <http://reviews.gem5.org/r/1595/diff/1/?file=32842#file32842line102>
> >
> > Should this not also include dir_cntrls while we are at it?
Apparently the directory (all in fact) controllers were children of the
'System' object instead of the 'RubySystem' object. I updated the patch so that
they become part of ruby_system, and because the Sequencer is a child of the L1
Controller, it inherits the RubySystem clock period now. Also, the previous
revision of this patch created a add child warning:
add_child('cpu_sequencers'): child 'sequencer sequencer sequencer sequencer
sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer
sequencer sequencer sequencer sequencer' already has parent: since the
sequencer already had the L1 controller as a parent, and then I was reassigning
it a new parent 'RubySystem'. This update fixes the warning.
- Malek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1595/#review3778
-----------------------------------------------------------
On Jan. 4, 2013, 8:31 a.m., Malek Musleh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1595/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2013, 8:31 a.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9373:dc294cf7eb0b
> ---------------------------
> Config: Move Ruby Objs to RubySystem in obj hierarchy
>
> This patch moves the contollers to be children of the ruby_system instead of
> 'system' under the python object hierarchy. This is so that these objects can
> inherit some of the ruby_system's parameter values without resorting to
> calling a global system pointer during run-time. The Ruby Objects should be
> direct children of the ruby_system instead of the main system object.
>
> Testing:
>
>
> Diffs
> -----
>
> configs/ruby/MESI_CMP_directory.py b32ab6de58dbb750f9081468532d36e57e88516d
> configs/ruby/MI_example.py b32ab6de58dbb750f9081468532d36e57e88516d
> configs/ruby/MOESI_CMP_directory.py
> b32ab6de58dbb750f9081468532d36e57e88516d
> configs/ruby/MOESI_CMP_token.py b32ab6de58dbb750f9081468532d36e57e88516d
> configs/ruby/MOESI_hammer.py b32ab6de58dbb750f9081468532d36e57e88516d
>
> Diff: http://reviews.gem5.org/r/1595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Malek Musleh
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
