----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1609/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9458:1a12feac8b2a --------------------------- cpu: Refactor memory system checks CPUs need to test that the memory system is in the right mode in two places, when the CPU is initialized (unless it's switched out) and on a drainResume(). This led to some code duplication in the CPU models. This changeset introduces the verifyMemoryMode() method which is called by BaseCPU::init() if the CPU isn't switched out. The individual CPU models are responsible for calling this method when resuming from a drain as this code is CPU model specific. Diffs ----- src/cpu/base.hh 56610ab73040 src/cpu/base.cc 56610ab73040 src/cpu/inorder/cpu.hh 56610ab73040 src/cpu/inorder/cpu.cc 56610ab73040 src/cpu/o3/cpu.hh 56610ab73040 src/cpu/o3/cpu.cc 56610ab73040 src/cpu/simple/atomic.hh 56610ab73040 src/cpu/simple/atomic.cc 56610ab73040 src/cpu/simple/timing.hh 56610ab73040 src/cpu/simple/timing.cc 56610ab73040 Diff: http://reviews.gem5.org/r/1609/diff/ Testing ------- Thanks, Ali Saidi _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
