> On Jan. 12, 2013, 8:50 p.m., Nilay Vaish wrote: > > In my opinion, we should remove all references to arm_detailed cpu > > from the scripts. It was a bad decision to include this cpu in the > > configuration scripts. We have ended up with several cluttered scripts. > > And we have created a precedence for developers / interested parties > > to submit / commit patches that add more such configurations to the > > existing scripts. I am not opposed to defining such configurations, > > in particular I am fine with the file O3_ARM_v7a.py. But including > > this configuration in all other scripts seems completely incorrect.
The reason I think they should be accessible in the scripts is that users will find it harder to use them if they're not -- or just not use them at all. Clearly the first way it was done wasn't ideal, but I think this changes moves into the correct direction. I think the next step would be to make the various configurations auto-detected and at this point the cache config script is the only place that has mention of it (assuming all the other submitted patches are applied). - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1608/#review3821 ----------------------------------------------------------- On Jan. 7, 2013, 11:31 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1608/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 11:31 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9457:fd01ef3f4a58 > --------------------------- > config: Remove O3 dependencies > > The default cache configuration script currently import the O3_ARM_v7a > model configuration, which depends on the O3 CPU. This breaks if gem5 > has been compiled without O3 support. This changeset removes the > dependency by only importing the model if it is requested by the > user. As a bonus, it actually removes some code duplication in the > configuration scripts. > > > Diffs > ----- > > configs/common/CacheConfig.py 56610ab73040 > > Diff: http://reviews.gem5.org/r/1608/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
