----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1624/#review3834 -----------------------------------------------------------
I think you should describe what broke since changeset 8932. It will be good if you can point out the patch which did some thing that was not correct. This might help in avoiding problems in the future. - Nilay Vaish On Jan. 14, 2013, 10:58 a.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1624/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 10:58 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9470:963e28295898 > --------------------------- > ruby: ruby tester support for separate instr and data ports > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > The patch also includes better DPRINTFs and other minor improvments. > > *Note* This patch was created by Brad Beckmann ([email protected]) > > > Diffs > ----- > > configs/example/ruby_random_test.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/cpu/testers/rubytest/Check.cc 794711cac18b0b5b47782675d45b886f2c31449c > src/cpu/testers/rubytest/CheckTable.cc > 794711cac18b0b5b47782675d45b886f2c31449c > src/cpu/testers/rubytest/RubyTester.hh > 794711cac18b0b5b47782675d45b886f2c31449c > src/cpu/testers/rubytest/RubyTester.cc > 794711cac18b0b5b47782675d45b886f2c31449c > src/cpu/testers/rubytest/RubyTester.py > 794711cac18b0b5b47782675d45b886f2c31449c > > Diff: http://reviews.gem5.org/r/1624/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
