> On Jan. 17, 2013, 8:36 a.m., Nathan Binkert wrote: > > I'm not opposed to code like this, but whenever we take in external code, > > there are license issues that we need to be careful of. I'd prefer to > > never see GPL language (and I believe that they give us permission to > > simply remove it). We also require license text on all files. > > > > Ali, Steve? You guys should look at this.
You're correct: "libfdt is dual licensed: you can use it either under the terms of * the GPL, or the BSD license, at your option." > On Jan. 17, 2013, 8:36 a.m., Nathan Binkert wrote: > > SConstruct, line 1031 > > <http://reviews.gem5.org/r/1650/diff/1/?file=33298#file33298line1031> > > > > I'd like to see some readme file that contains some (even minimal) sort > > of documentation on what this thing is for, and where it came from. Ok, I can add a README. > On Jan. 17, 2013, 8:36 a.m., Nathan Binkert wrote: > > ext/libfdt/fdt.c, line 25 > > <http://reviews.gem5.org/r/1650/diff/1/?file=33301#file33301line25> > > > > I think we should just drop the GPL part and only keep the BSD part of > > the license. Agreed. > On Jan. 17, 2013, 8:36 a.m., Nathan Binkert wrote: > > ext/libfdt/fdt.h, line 1 > > <http://reviews.gem5.org/r/1650/diff/1/?file=33300#file33300line1> > > > > This file has no license. Will fix and repost. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1650/#review3860 ----------------------------------------------------------- On Jan. 17, 2013, 8:03 a.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1650/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 8:03 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9475:425491d7f106 > --------------------------- > ext lib: add libfdt to enable flattened device tree support > > this patch adds libfdt, a library necessary for supporting > flattened device tree support in current and future versions of > the linux/android kernel for ARM. > > > Diffs > ----- > > SConstruct 23c3e1c0e9e47c39733f7e267bf0b6a05b082059 > ext/libfdt/SConscript PRE-CREATION > ext/libfdt/fdt.h PRE-CREATION > ext/libfdt/fdt.c PRE-CREATION > ext/libfdt/fdt_empty_tree.c PRE-CREATION > ext/libfdt/fdt_ro.c PRE-CREATION > ext/libfdt/fdt_rw.c PRE-CREATION > ext/libfdt/fdt_strerror.c PRE-CREATION > ext/libfdt/fdt_sw.c PRE-CREATION > ext/libfdt/fdt_wip.c PRE-CREATION > ext/libfdt/libfdt.h PRE-CREATION > ext/libfdt/libfdt_env.h PRE-CREATION > ext/libfdt/libfdt_internal.h PRE-CREATION > > Diff: http://reviews.gem5.org/r/1650/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
