> On Jan. 14, 2013, 12:03 p.m., Nilay Vaish wrote: > > src/mem/ruby/system/SConscript, line 41 > > <http://reviews.gem5.org/r/1629/diff/1/?file=33155#file33155line41> > > > > Do we still need this line? > > Derek Hower wrote: > The WireBuffer object isn't removed by this patch, so we still need this > line.
The question here is about the file. Since WireBuffer.py has been moved to AtomicMessageInterface.py, why would we need this statement? - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1629/#review3836 ----------------------------------------------------------- On Jan. 16, 2013, 11:28 a.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1629/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 11:28 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9475:6f76e7b25361 > --------------------------- > ruby: Atomic Message Interface Support > > This patch adds Atomic Message Interfaces to SLICC/Ruby. AMIs look a lot like > conventional MessageBuffers, except they guarantee immediate consumption of > an enqueued message by the receiving controller, before any other activity. > This feature simplifies protocols with co-located controllers where messages > and information can be passed between the two, without worrying about > unecessary races. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Types.sm > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/SConscript 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/slicc_interface/AbstractController.hh > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/system/SConscript 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/system/WireBuffer.hh 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/system/WireBuffer.cc 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/ruby/system/WireBuffer.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/ActionDeclAST.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/EnqueueStatementAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/ExprAST.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/ExprStatementAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/FuncCallExprAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/IfStatementAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/InPortDeclAST.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/MethodCallExprAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/OutPortDeclAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/PeekStatementAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/StallAndWaitStatementAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/StatementAST.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/ast/StatementListAST.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/parser.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Action.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Event.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/StateMachine.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/SymbolTable.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Transition.py > 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Type.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Var.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Var.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/Var.py 794711cac18b0b5b47782675d45b886f2c31449c > src/mem/slicc/symbols/__init__.py 794711cac18b0b5b47782675d45b886f2c31449c > > Diff: http://reviews.gem5.org/r/1629/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
