----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1659/#review3879 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Jan. 21, 2013, 2:26 p.m., Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1659/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2013, 2:26 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9477:d0aacc54ce > --------------------------- > tracing: Load weak symbols for function tracing > > Hello! Without loading weak symbols into gem5, some function names and the > given PC cannot correspond correctly, because the binding attributes of > function names in an ELF file are not only STB_GLOBAL or STB_LOCAL, but also > STB_WEAK. We can load weak symbols and local symbols at the same time to get > more precise function tracing and profiling results. > > For example, in m5out/ftrace.system.cpu, the function tracing results of > tests/test-progs/hello/bin/mips/linux/hello: > Without weak symbols: > 2087500: __libc_csu_fini (8000) > 2294500: __libc_csu_fini (8000) > With weak symbols: > 2087500: __errno_location (8000) > 2294500: __errno_location (8000) > > > Diffs > ----- > > src/base/loader/elf_object.cc d0aacc54cee9 > > Diff: http://reviews.gem5.org/r/1659/diff/ > > > Testing > ------- > > > Thanks, > > Deyuan Guo > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
