> On Jan. 21, 2013, 3:57 p.m., Ali Saidi wrote: > > src/arch/arm/linux/system.cc, line 148 > > <http://reviews.gem5.org/r/1651/diff/2/?file=33321#file33321line148> > > > > I think this needs a bit more error checking. You should do the dynamic > > cast and then check success, after that you should call addBootCmdLine. > > With this code if the dynamic cast fails the program will crash.
Let me know if the new patch is ok. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1651/#review3877 ----------------------------------------------------------- On Jan. 23, 2013, 7:26 a.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1651/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2013, 7:26 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9480:087c453de8cc > --------------------------- > loader: add a flattened device tree blob (dtb) object > > this adds a dtb_object so the loader can load in the dtb > file for linux/android ARM kernels. > > > Diffs > ----- > > src/arch/arm/linux/system.cc f9e76b1eb79a2cfe9869e84dbbdf3aaa4a29cb0e > src/base/SConscript f9e76b1eb79a2cfe9869e84dbbdf3aaa4a29cb0e > src/base/loader/dtb_object.hh PRE-CREATION > src/base/loader/dtb_object.cc PRE-CREATION > src/base/loader/object_file.cc f9e76b1eb79a2cfe9869e84dbbdf3aaa4a29cb0e > > Diff: http://reviews.gem5.org/r/1651/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
