----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1639/#review3901 -----------------------------------------------------------
It seems to me that the majority of the code in this script should be abstracted into classes/functions which are then used by the script, but could also be used by others. I'm not asking for added functionality, just a separation so that it can be used without copy/paste. - Nathan Binkert On Jan. 15, 2013, 10:29 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1639/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 10:29 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9492:35ce7e2339f3 > --------------------------- > stats: Add example script to extract stats from SQL database > > This patch adds a simple python stript which is able to extract data from the > database based on the name of the stat. It is able to either print the result > to the screen, or write it to an output CSV file. It extracts the data for a > single dump. > > This script is designed as a rough reference for the creation of more > sophisticated stats manipulation scripts, and is therefore not feature rich. > > > Diffs > ----- > > util/stats/extractSQLStats.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1639/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
