----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1710/#review4066 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 18, 2013, 6:02 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1710/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 6:02 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9544:d8e3bd9d3fc2 > --------------------------- > sim: Make clock private and access using clockPeriod() > > This patch makes the clock member private to the ClockedObject and > forces all children to access it using clockPeriod(). This makes it > impossible to inadvertently change the clock, and also makes it easier > to transition to a situation where the clock is derived from e.g. a > clock domain, or through a multiplier. > > > Diffs > ----- > > src/dev/arm/timer_cpulocal.hh 0ac00d9a8aaf > src/dev/arm/timer_cpulocal.cc 0ac00d9a8aaf > src/mem/bus.hh 0ac00d9a8aaf > src/mem/bus.cc 0ac00d9a8aaf > src/mem/cache/cache_impl.hh 0ac00d9a8aaf > src/mem/cache/prefetch/base.cc 0ac00d9a8aaf > src/mem/coherent_bus.hh 0ac00d9a8aaf > src/mem/coherent_bus.cc 0ac00d9a8aaf > src/mem/noncoherent_bus.hh 0ac00d9a8aaf > src/mem/noncoherent_bus.cc 0ac00d9a8aaf > src/mem/ruby/system/RubyMemoryControl.cc 0ac00d9a8aaf > src/sim/clocked_object.hh 0ac00d9a8aaf > > Diff: http://reviews.gem5.org/r/1710/diff/ > > > Testing > ------- > > All regressions passing (excluding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
