> On March 12, 2013, 3:36 p.m., Andreas Hansson wrote: > > I find the flow and ownership/compartmentalisation really confusing. The > > topology creates the routers in makeTopology, but does not store any > > information about them. This is then passed to the network and the length > > communicated back to the topology. Would it be possible to: a) create the > > network and remember what it needs to remember about it, 2) not inform the > > topology about the num_switches at all?
It seems we do not need a separate topology class. The functionality should probably be merged in to the network class. But all that will be in a separate patch. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1762/#review4097 ----------------------------------------------------------- On March 8, 2013, 9:58 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1762/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 9:58 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9589:fb49923e3ce2 > --------------------------- > ruby: network: move routers from topology to network > > > Diffs > ----- > > configs/ruby/Ruby.py e507dc092ca3 > src/mem/ruby/network/Network.py e507dc092ca3 > src/mem/ruby/network/Topology.cc e507dc092ca3 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc e507dc092ca3 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc e507dc092ca3 > src/mem/ruby/network/simple/SimpleNetwork.cc e507dc092ca3 > > Diff: http://reviews.gem5.org/r/1762/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
