----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1771/#review4122 -----------------------------------------------------------
src/mem/bus.hh <http://reviews.gem5.org/r/1771/#comment3959> A instead of An? - Nilay Vaish On March 14, 2013, 7:27 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1771/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 7:27 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9589:4eb79191ee1f > --------------------------- > mem: Separate waiting for the bus and waiting for a peer > > This patch splits the retryList into a list of ports that are waiting > for the bus itself to become available, and a map that tracks the > ports where forwarding failed due to a peer not accepting the > packet. Thus, when a retry reaches the bus, it can be sent to the > appropriate port that initiated that transaction. > > As a consequence of this patch, only ports that are really ready to go > will get a retry, thus reducing the amount of redundant failed > attempts. This patch also makes it easier to reason about the order of > servicing requests as the ports waiting for the bus are now clearly > FIFO and much easier to change if desired. > > > Diffs > ----- > > src/mem/bus.hh 1a21964b7227 > src/mem/bus.cc 1a21964b7227 > src/mem/coherent_bus.hh 1a21964b7227 > src/mem/coherent_bus.cc 1a21964b7227 > src/mem/noncoherent_bus.hh 1a21964b7227 > src/mem/noncoherent_bus.cc 1a21964b7227 > > Diff: http://reviews.gem5.org/r/1771/diff/ > > > Testing > ------- > > With stats updates, all regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
