----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1781/#review4144 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On March 21, 2013, 10:12 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1781/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 10:12 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9595:1a0b5df0e0ae > --------------------------- > dev/arm: get rid of AmbaDev namespace > > It was confusing having an AmbaDev namespace along with an > AmbaDevice class. The namespace stuff is now moved in to > a new base AmbaDevice class, which is a mixin for classes > AmbaPioDevice (the former AmbaDevice) and AmbaDmaDevice > to provide the readId function as an inherited member function. > > > Diffs > ----- > > src/dev/arm/RealView.py e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/amba_device.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/amba_device.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/amba_fake.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/amba_fake.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/kmi.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/pl011.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/pl011.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/pl111.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/rtc_pl031.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/timer_sp804.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/arm/timer_sp804.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > > Diff: http://reviews.gem5.org/r/1781/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
