----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1780/#review4145 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On March 21, 2013, 10:11 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1780/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 10:11 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9594:3389e262b2fd > --------------------------- > devices: make more classes derive from BasicPioDevice > > A couple of devices that have single fixed memory mapped regions > were not derived from BasicPioDevice, when that's exactly > the functionality that BasicPioDevice provides. This patch > gets rid of a little bit of redundant code by making those > devices actually do so. > > Also fixed the weird case of X86ISA::Interrupts, where > the class already did derive from BasicPioDevice but > didn't actually use all the features it could have. > > > Diffs > ----- > > src/arch/x86/interrupts.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/arch/x86/interrupts.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/Pci.py e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/pciconfigall.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/pciconfigall.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i82094aa.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i82094aa.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > > Diff: http://reviews.gem5.org/r/1780/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
