----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1778/#review4150 -----------------------------------------------------------
Ship it! Ship It! - Jason Power On March 21, 2013, 5:25 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1778/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 5:25 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9603:64f4a65ff5cf > --------------------------- > ruby: convert topology to normal object > The Topology class in Ruby does not need to be a sim object. This patch > turns it into a regular class. The topology object is now created in the > constructor of the Network class. All the parameters for the topology > class have been moved to the network class. > > > Diffs > ----- > > configs/ruby/Ruby.py b6a47b43f4df > src/mem/ruby/network/Network.hh b6a47b43f4df > src/mem/ruby/network/Network.cc b6a47b43f4df > src/mem/ruby/network/Network.py b6a47b43f4df > src/mem/ruby/network/Topology.hh b6a47b43f4df > src/mem/ruby/network/Topology.cc b6a47b43f4df > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc b6a47b43f4df > > Diff: http://reviews.gem5.org/r/1778/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
