----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1782/#review4160 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On March 21, 2013, 10:13 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1782/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 10:13 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9596:2cf97b6e9c31 > --------------------------- > dev: consistently end device classes in 'Device' > > PciDev and IntDev stuck out as the only device classes that > ended in 'Dev' rather than 'Device'. This patch takes care > of that inconsistency. > > Note that you may need to delete pre-existing files matching > build/*/python/m5/internal/param_* as scons does not pick up > indirect dependencies on imported python modules when generating > params, and the PciDev -> PciDevice rename takes place in a > file (dev/Device.py) that gets imported quite a bit. > > > Diffs > ----- > > src/arch/x86/interrupts.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/arch/x86/interrupts.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/Pci.py e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/copy_engine.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/copy_engine.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/etherdevice.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/i8254xGBe.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/ide_ctrl.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/ide_ctrl.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/ns_gige.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/pciconfigall.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/pcidev.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/pcidev.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/sinic.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/SConscript e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i82094aa.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i82094aa.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i8259.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/i8259.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/intdev.hh e63321487404c8c948e56e9574b61c2a7fd87d0e > src/dev/x86/intdev.cc e63321487404c8c948e56e9574b61c2a7fd87d0e > > Diff: http://reviews.gem5.org/r/1782/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
