----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1797/#review4188 -----------------------------------------------------------
How about having assert statements instead? - Nilay Vaish On March 28, 2013, 3:29 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1797/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 3:29 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9621:813a740147cc > --------------------------- > mem: Replace check with panic where inhibited should not happen > > This patch changes the SimpleTimingPort and RubyPort to panic on > inhibited requests as this should never happen in either of the > cases. The SimpleTimingPort is only used for the I/O devices PIO port > and the DMA devices config port and should thus never see an inhibited > request. Similarly, the SimpleTimingPort is also used for the > MessagePort in x86, and there should also not be any cases where the > port sees an inhibited request. > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.cc 89aa34e10625 > src/mem/tport.cc 89aa34e10625 > > Diff: http://reviews.gem5.org/r/1797/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
