----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1802/#review4193 -----------------------------------------------------------
Seems fine. - Nilay Vaish On March 28, 2013, 3:32 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1802/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 3:32 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9627:e5f0194b3034 > --------------------------- > mem: More descriptive enum names for address mapping > > This patch changes the slightly ambigious names used for the address > mapping scheme to be more descriptive, and actually spell out what > they do. With this patch we also open up for adding more flavours of > open- and close-type mappings, i.e. interleaving across channels with > the open map. > > > Diffs > ----- > > src/mem/SimpleDRAM.py 89aa34e10625 > src/mem/simple_dram.cc 89aa34e10625 > > Diff: http://reviews.gem5.org/r/1802/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
