----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1309/#review4200 -----------------------------------------------------------
Ship it! We've tested this patch thoroughly internally, and I'd say it is ready to ship. - Joel Hestness On Aug. 8, 2012, 8:08 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1309/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 8:08 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9124:a9208bc27e58 > --------------------------- > Ruby: Add field to slicc machine for generic type > This allows you to have (i.e.) an L2 cache that is not named "L2Cache" > but is still a GenericMachineType_L2Cache. This is particularly > helpful if the protocol has multiple L2 controllers. > > > Diffs > ----- > > src/mem/slicc/symbols/Type.py b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1309/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
