On Tue, 9 Apr 2013, Joel Hestness wrote:



On April 8, 2013, 8:11 a.m., Andreas Hansson wrote:
src/mem/ruby/system/RubyPort.cc, line 500
<http://reviews.gem5.org/r/1813/diff/1/?file=34762#file34762line500>

    Could you add a comment that the request does not need a response and is 
thus deleted with the packet.

    Also, it would be good to highlight that the same packet (potentially 
altered) is now sent to all the ports and this is making assumptions about what 
they do (or don't do) to it.

    Thanks

Added these comments to the patch for checkin



Why not move the line of code back inside the loop?

--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to