----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1825/#review4240 -----------------------------------------------------------
I am guessing you read some x86 instruction manual to figure this out. Can you mention the manual you read? After reading a code snippet that appears in "AMD64 Architecture Programmer’s Manual Volume 3: General-Purpose and System Instructions", it appears to me that the suggested change may not be required in all the cases that 'ret' instruction needs to handle. - Nilay Vaish On April 17, 2013, 5 a.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1825/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 5 a.m.) > > > Review request for Default. > > > Description > ------- > > x86: bugfix: lret instruction has to increment the stack pointer > lret does not increment the stack pointer which results in misbehavior. > I am not sure if this is the best way to fix this, but it works for me. > > > Diffs > ----- > > src/arch/x86/isa/insts/general_purpose/control_transfer/xreturn.py > 531a176f863d4844af311df515d435b0bb06163c > > Diff: http://reviews.gem5.org/r/1825/diff/ > > > Testing > ------- > > Tested with a custom kernel. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
