----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1827/#review4250 -----------------------------------------------------------
Ship it! Overall it looks good, with only some minor things. The only thing I'd like you to change is the keyword. If the list (http://gem5.org/Commit_Access) needs additional items we should kick off a discussion. "The keyword should be one of the following: base, stats, sim, config, ruby, mem, arm, x86, arch, cpu, dev, scons, alpha, mips, power, sparc" src/cpu/pred/tournament.cc <http://reviews.gem5.org/r/1827/#comment4035> I would suggest to move the ceilLog2 intialisation here. If not, please initialise them to 0 here to not upset static code analysers :-) src/cpu/pred/tournament.cc <http://reviews.gem5.org/r/1827/#comment4036> Remove the commented out line and preferably move the initialisation to the initialiser list - Andreas Hansson On April 17, 2013, 1:34 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1827/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 1:34 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9638:40448fbc9f0c > --------------------------- > branch pred: get rid of local/globalHistoryBits params > > having separate params for the local/globalHistoryBits and the > local/globalPredictorSize can lead to inconsistencies if they > are not carefully set. this patch dervies the number of bits > necessary to index into the local/global predictors based on > their size. > > the value of the localHistoryTableSize for the ARM O3 CPU has been > increased to 1024 from 64, which is more accurate for an A15 based > on some correlation against A15 hardware. > > > Diffs > ----- > > configs/common/O3_ARM_v7a.py c22628fa25646077ed4f18a811f348b47a64bd5d > src/cpu/pred/BranchPredictor.py c22628fa25646077ed4f18a811f348b47a64bd5d > src/cpu/pred/tournament.cc c22628fa25646077ed4f18a811f348b47a64bd5d > > Diff: http://reviews.gem5.org/r/1827/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
