----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1846/#review4281 -----------------------------------------------------------
Ship it! Looks good to me - Andreas Hansson On April 24, 2013, 10:55 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1846/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 10:55 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9680:a3a1b771b3d0 > --------------------------- > ruby: remove periodic event from Profiler > The Profiler class does not need an event for dumping statistics > periodically. This is because there is a method for dumping statistics > for all the sim objects periodically. Since Ruby is a sim object, its > statistics are also included. > > > Diffs > ----- > > src/mem/ruby/profiler/Profiler.hh df8e64db0fd8 > src/mem/ruby/profiler/Profiler.cc df8e64db0fd8 > > Diff: http://reviews.gem5.org/r/1846/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
