----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1638/#review4290 -----------------------------------------------------------
I'm glad to see you using a real database! src/python/m5/stats/__init__.py <http://reviews.gem5.org/r/1638/#comment4061> Can this reopen an existing database? If so, the create_tables is going to be a problem. If not, does this error out or delete the original? src/python/m5/stats/__init__.py <http://reviews.gem5.org/r/1638/#comment4060> Is it possible that subsequent calls to this have information that the initial ones do not? Do you support reopening an existing file to add data to it? If not, you should probably add some error code. src/python/m5/stats/__init__.py <http://reviews.gem5.org/r/1638/#comment4062> the format of the identifier as "init_SQL" follows no existing convention in the code base that I know of :) I'd prefer init_sql. Of course, we are inconsistent with how we treat src/python/m5/stats/__init__.py <http://reviews.gem5.org/r/1638/#comment4059> this looks like an accidental duplicate src/python/m5/stats/sql.py <http://reviews.gem5.org/r/1638/#comment4058> This try catch seems superfluous. src/python/m5/stats/sql.py <http://reviews.gem5.org/r/1638/#comment4057> You're duplicating stuff here. Shouldn't create_tables simply be declared after all of the tables and simply be create_tables = Base.metadata.create_all - Nathan Binkert On April 24, 2013, 3:23 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1638/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 3:23 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9709:8a3d4a250bc9 > --------------------------- > stats: Add SQLite database as an output format > > This patch adds a second output format (in addition to the stats.txt) which > stores the stats in an SQLite database using SQLAlchemy. The information about > each stat is written to the database once to avoid repeated data. Each dump is > given an accociated dump ID which is based on the the number of dumps stored > in the database. > > To enable the SQL output, a parameter has been added to gem5. For example, > ./build/ARM/gem5.fast --stats-db-file=stats.db .... > will stored the stats in a file called "stats.db". By default SQL stats are > disabled. In order to disable the text-based stats output use --stats-file="". > For backwards compatibility the default behaviour creates stats.txt. > > In case SQLAlchemy is unavailable, only stats.txt is generated. If text-based > stats are explicitly disabled, gem5 will fatal. > > > Diffs > ----- > > src/python/SConscript 773aae0990ae > src/python/m5/main.py 773aae0990ae > src/python/m5/stats/__init__.py 773aae0990ae > src/python/m5/stats/sql.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1638/diff/ > > > Testing > ------- > > Generated a number of databases > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
