> On April 26, 2013, 9:52 a.m., Nilay Vaish wrote: > > src/proto/protoio.hh, line 124 > > <http://reviews.gem5.org/r/1831/diff/1/?file=35226#file35226line124> > > > > Is this comment on the Zero Copy correct?
yip > On April 26, 2013, 9:52 a.m., Nilay Vaish wrote: > > src/proto/protoio.hh, line 196 > > <http://reviews.gem5.org/r/1831/diff/1/?file=35226#file35226line196> > > > > Similarly, is the stream here zero copy? yip > On April 26, 2013, 9:52 a.m., Nilay Vaish wrote: > > src/proto/protoio.cc, line 86 > > <http://reviews.gem5.org/r/1831/diff/1/?file=35227#file35227line86> > > > > Do you have any idea why that internal counter is present in protobuf? Haven't looked into it, as it is nothing we can change. > On April 26, 2013, 9:52 a.m., Nilay Vaish wrote: > > src/proto/protoio.cc, line 95 > > <http://reviews.gem5.org/r/1831/diff/1/?file=35227#file35227line95> > > > > Why change this line? A small performance tweak. I can make this a separate patch if you want. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1831/#review4292 ----------------------------------------------------------- On April 22, 2013, 2:48 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1831/ > ----------------------------------------------------------- > > (Updated April 22, 2013, 2:48 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9670:8c4e2cd9c0f8 > --------------------------- > base: Avoid size limitation on protobuf coded streams > > This patch changes how the streams are created to avoid the size > limitation on the coded streams. As we only read/write a single > message at a time, there is never any message larger than a few > bytes. However, the coded stream eventually complains that its > internal counter reaches 64+ MByte if the total file size exceeds this > value. > > Based on suggestions in the protobuf discussion forums, the coded > stream is now created for every message that is read/written. The > result is that the internal byte count never goes about tens of bytes, > and we can read/write any size file that the underlying file I/O can > handle. > > > Diffs > ----- > > src/proto/protoio.hh c5b24e8ed428 > src/proto/protoio.cc c5b24e8ed428 > > Diff: http://reviews.gem5.org/r/1831/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
