----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1796/#review4309 -----------------------------------------------------------
Ship it! While it doesn't help much, it is a step in the right direction, so I think we should commit it. Simply for debugging memory leaks it would be nice to have all the classes have proper destructors. - Ali Saidi On March 27, 2013, 3:39 p.m., Xiangyu Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1796/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 3:39 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9618:0d84548ef3e3 > --------------------------- > mem: add cache class destructor to avoid memory leak > Make valgrind a little bit happier > (a test patch from a first-time code contributor) > > > Diffs > ----- > > src/mem/cache/cache.hh 0a4b702628bd > src/mem/cache/cache_impl.hh 0a4b702628bd > > Diff: http://reviews.gem5.org/r/1796/diff/ > > > Testing > ------- > > > Thanks, > > Xiangyu Dong > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
