----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1822/#review4310 -----------------------------------------------------------
Ship it! This seems good, but I think the Option name is a little bit confusing. How about --l1-bank-model rather than --l1-enable-bank? (and similar for the other ones. - Ali Saidi On April 17, 2013, 10:56 a.m., Xiangyu Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1822/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 10:56 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9638:187a47b3551d > --------------------------- > mem: add a knob to turn on/off bank blocking model > By default, the cache bank model is turned off to match the main branch > regression result. > Enabling this feature by --l1-bank-model, --l2-bank-model, --l3-bank-model > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 6d4158ff7b82 > src/mem/cache/base.cc 6d4158ff7b82 > src/mem/cache/BaseCache.py 6d4158ff7b82 > src/mem/cache/base.hh 6d4158ff7b82 > configs/common/Options.py 6d4158ff7b82 > configs/common/CacheConfig.py 6d4158ff7b82 > > Diff: http://reviews.gem5.org/r/1822/diff/ > > > Testing > ------- > > > Thanks, > > Xiangyu Dong > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
