----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1864/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9708:fb9ab7597f23 --------------------------- mem: Spring cleaning of MSHR and MSHRQueue This patch does some minor tidying up of the MSHR and MSHRQueue. The clean up started as part of some ad-hoc tracing and debugging, but seems worthwhile enough to go in as a separate patch. The highlights of the changes are reduced scoping (private) members where possible, avoiding redundant new/delete, and constructor initialisation to please static code analyzers. Diffs ----- src/mem/cache/mshr.hh eb075b2b925a src/mem/cache/mshr.cc eb075b2b925a src/mem/cache/mshr_queue.hh eb075b2b925a src/mem/cache/mshr_queue.cc eb075b2b925a Diff: http://reviews.gem5.org/r/1864/diff/ Testing ------- All regressions pass Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
