----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1892/#review4381 -----------------------------------------------------------
looks fine, but if we don't have to embed our own random number generator in the middle of the decode cache code I think that would be best. src/cpu/decode_cache.hh <http://reviews.gem5.org/r/1892/#comment4110> is this appreciably faster than rand() or better yet the Random class in base which is just using a mersenne twister? - Ali Saidi On June 3, 2013, 5:36 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1892/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 5:36 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9739:245243cf497d > --------------------------- > cpu: Limit the size of the decode cache > > The decode cache can in some cases grow really large, which can even > prevent some systems from booting. This changeset adds a the ability > to limit the size of the decode cache and randomly prune a fraction of > the cache once it reaches its upper limit. The default behavior on > most architectures is now to allow 4k pages in the cache and prune 50% > once this limit is reached. > > > Diffs > ----- > > src/arch/generic/decode_cache.hh 304a37519d11 > src/arch/x86/decoder.hh 304a37519d11 > src/cpu/decode_cache.hh 304a37519d11 > > Diff: http://reviews.gem5.org/r/1892/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
