----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1919/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9756:0f18925d4ae4 --------------------------- x86: Fix the flag handling code in FABS and FCHS This changeset fixes two problems in the FABS and FCHS implementation. First, the ISA parser expects the assignment in flag_code to be a pure assignment and not an and-assignment, which leads to the isa_parser omitting the misc reg update. Second, the FCHS and FABS macro-ops don't set the SetStatus flag, which means that the default micro-op version, which doesn't update FSW, is executed. Diffs ----- src/arch/x86/isa/microops/fpop.isa 9df73385c878 src/arch/x86/isa/insts/x87/arithmetic/change_sign.py 9df73385c878 Diff: http://reviews.gem5.org/r/1919/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
