On Wed, 12 Jun 2013, Lena Olson wrote:


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1921/
-----------------------------------------------------------

Review request for Default.


Description
-------

Changeset 9756:8956d858a9e6
---------------------------
ruby: restrict Address to being a type and not a variable name
Change all occurrances of Address as a variable name to instead use Addr.
Address is an allowed name in slicc even when Address is also being used as a
type, leading to declarations of "Address Address". While this works, it
prevents adding another field of type Address because the compiler then thinks
Address is a variable name, not type.



I think there should be a concomitant patch that prevents using the same name for two different symbols in a .sm file.

--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to