> On June 24, 2013, 6:29 p.m., Steve Reinhardt wrote: > > src/mem/cache/base.cc, line 786 > > <http://reviews.gem5.org/r/1931/diff/1-2/?file=36293#file36293line786> > > > > I'd make this warning a little more explicit, e.g., "Consider using > > FALRU tags for a fully associative cache". Though if FALRU tags are still > > broken (as I think someone claimed), we may not want to do that yet.
All happy? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1931/#review4467 ----------------------------------------------------------- On June 25, 2013, 10:28 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1931/ > ----------------------------------------------------------- > > (Updated June 25, 2013, 10:28 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9800:a66b30dc18fe > --------------------------- > mem: Reorganize cache tags and make them a SimObject > > This patch reorganizes the cache tags to allow more flexibility to > implement new replacement policies. The base tags class is now a > clocked object so that derived classes can use a clock if they need > one. Also having deriving from SimObject allows specialized Tag > classes to be swapped in/out in .py files. > > The cache set is now templatized to allow it to contain customized > cache blocks with additional informaiton. This involved moving code to > the .hh file and removing cacheset.cc. > > The statistics belonging to the cache tags are now including ".tags" > in their name. Hence, the stats need an update to reflect the change > in naming. > > > Diffs > ----- > > src/mem/cache/BaseCache.py 5fe711f40d18 > src/mem/cache/base.cc 5fe711f40d18 > src/mem/cache/cache.hh 5fe711f40d18 > src/mem/cache/cache_impl.hh 5fe711f40d18 > src/mem/cache/tags/SConscript 5fe711f40d18 > src/mem/cache/tags/Tags.py PRE-CREATION > src/mem/cache/tags/base.hh 5fe711f40d18 > src/mem/cache/tags/base.cc 5fe711f40d18 > src/mem/cache/tags/cacheset.hh 5fe711f40d18 > src/mem/cache/tags/cacheset.cc 5fe711f40d18 > src/mem/cache/tags/fa_lru.hh 5fe711f40d18 > src/mem/cache/tags/fa_lru.cc 5fe711f40d18 > src/mem/cache/tags/lru.hh 5fe711f40d18 > src/mem/cache/tags/lru.cc 5fe711f40d18 > > Diff: http://reviews.gem5.org/r/1931/diff/ > > > Testing > ------- > > After some sedding of the stats (for tag stats include .tags in the name) all > regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
