----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1937/#review4505 -----------------------------------------------------------
Ship it! Seems fine to me. - Nilay Vaish On July 5, 2013, 2:16 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1937/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 2:16 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9812:f5891921126c > --------------------------- > power: Add voltage domains to the clock domains > > This patch adds the notion of voltage domains, and groups clock > domains that operate under the same voltage (i.e. power supply) into > domains. Each clock domain is required to be associated with a voltage > domain, and the latter requires the voltage to be explicitly set. > > A voltage domain is an independently controllable voltage supply being > provided to section of the design. Thus, if you wish to perform > dynamic voltage scaling on a CPU, its clock domain should be > associated with a separate voltage domain. > > The current implementation of the voltage domain does not take into > consideration cases where there are derived voltage domains running at > ratio of native voltage domains, as with the case where there can be > on-chip buck/boost (charge pumps) voltage regulation logic. > > The regression and configuration scripts are updated with a generic > voltage domain for the system, and one for the CPUs. > > > Diffs > ----- > > configs/common/Options.py 86b426640960 > configs/example/fs.py 86b426640960 > configs/example/se.py 86b426640960 > src/python/m5/params.py 86b426640960 > src/python/m5/util/convert.py 86b426640960 > src/sim/ClockDomain.py 86b426640960 > src/sim/SConscript 86b426640960 > src/sim/VoltageDomain.py PRE-CREATION > src/sim/clock_domain.hh 86b426640960 > src/sim/clock_domain.cc 86b426640960 > src/sim/voltage_domain.hh PRE-CREATION > src/sim/voltage_domain.cc PRE-CREATION > tests/configs/base_config.py 86b426640960 > tests/configs/memtest-ruby.py 86b426640960 > tests/configs/memtest.py 86b426640960 > tests/configs/rubytest-ruby.py 86b426640960 > tests/configs/simple-timing-ruby.py 86b426640960 > tests/configs/tgen-simple-dram.py 86b426640960 > tests/configs/tgen-simple-mem.py 86b426640960 > tests/configs/twosys-tsunami-simple-atomic.py 86b426640960 > > Diff: http://reviews.gem5.org/r/1937/diff/ > > > Testing > ------- > > All regressions pass. Ran a number of the example scripts. > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
