----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1951/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 9817:5b617661ba4e --------------------------- config: Move the memory instantiation outside FSConfig This patch moves the instantiation of the memory controller outside FSConfig and instead relies on the mem_ranges to pass the information to the caller (e.g. fs.py or one of the regression scripts). The main motivation for this change is to expose the structural composition of the memory system and allow more tuning and configuration without adding a large number of options to the makeSystem functions. The patch updates the relevant example scripts to maintain the current functionality. As the order that ports are connected to the memory bus changes (in certain regresisons), some bus stats are shuffled around. For example, what used to be layer 0 is now layer 1. Going forward, options will be added to support the addition of multi-channel memory controllers. Diffs ----- configs/common/FSConfig.py 13ffc0066b76 configs/example/fs.py 13ffc0066b76 configs/example/ruby_fs.py 13ffc0066b76 configs/ruby/MESI_CMP_directory.py 13ffc0066b76 configs/ruby/MI_example.py 13ffc0066b76 configs/ruby/MOESI_CMP_directory.py 13ffc0066b76 configs/ruby/MOESI_CMP_token.py 13ffc0066b76 configs/ruby/MOESI_hammer.py 13ffc0066b76 configs/ruby/Network_test.py 13ffc0066b76 configs/ruby/Ruby.py 13ffc0066b76 tests/configs/alpha_generic.py 13ffc0066b76 tests/configs/arm_generic.py 13ffc0066b76 tests/configs/base_config.py 13ffc0066b76 tests/configs/memtest-ruby.py 13ffc0066b76 tests/configs/pc-o3-timing.py 13ffc0066b76 tests/configs/pc-simple-atomic.py 13ffc0066b76 tests/configs/pc-simple-timing-ruby.py 13ffc0066b76 tests/configs/pc-simple-timing.py 13ffc0066b76 tests/configs/pc-switcheroo-full.py 13ffc0066b76 tests/configs/realview-o3-checker.py 13ffc0066b76 tests/configs/realview-o3-dual.py 13ffc0066b76 tests/configs/realview-o3.py 13ffc0066b76 tests/configs/realview-simple-atomic-dual.py 13ffc0066b76 tests/configs/realview-simple-atomic.py 13ffc0066b76 tests/configs/realview-simple-timing-dual.py 13ffc0066b76 tests/configs/realview-simple-timing.py 13ffc0066b76 tests/configs/realview-switcheroo-atomic.py 13ffc0066b76 tests/configs/realview-switcheroo-full.py 13ffc0066b76 tests/configs/realview-switcheroo-o3.py 13ffc0066b76 tests/configs/realview-switcheroo-timing.py 13ffc0066b76 tests/configs/rubytest-ruby.py 13ffc0066b76 tests/configs/simple-timing-ruby.py 13ffc0066b76 tests/configs/t1000-simple-atomic.py 13ffc0066b76 tests/configs/tsunami-inorder.py 13ffc0066b76 tests/configs/tsunami-o3-dual.py 13ffc0066b76 tests/configs/tsunami-o3.py 13ffc0066b76 tests/configs/tsunami-simple-atomic-dual.py 13ffc0066b76 tests/configs/tsunami-simple-atomic.py 13ffc0066b76 tests/configs/tsunami-simple-timing-dual.py 13ffc0066b76 tests/configs/tsunami-simple-timing.py 13ffc0066b76 tests/configs/tsunami-switcheroo-full.py 13ffc0066b76 tests/configs/twosys-tsunami-simple-atomic.py 13ffc0066b76 tests/configs/x86_generic.py 13ffc0066b76 Diff: http://reviews.gem5.org/r/1951/diff/ Testing ------- All regressions pass Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
