> On July 15, 2013, 3:13 p.m., Ali Saidi wrote: > > Seems Ok to me as long as all the regressions still run (obviously the > > stats will change). Anyone else have input?
It needs a change or two. In it's current form, it would break FS. Here's a self-quote from an email with Korey a while back. "I also realized this current patch would break FS mode, since the frontend signals instruction fetch page faults by creating a nop with a fault attached (this patch would just discard that nop). So, checking for a fault would be required before discarding." I'm frantically trying to finish a thesis (defending in August), so probably won't get to it for a bit even though its a minor change. - Mitch ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1804/#review4512 ----------------------------------------------------------- On March 29, 2013, 7:40 p.m., Mitch Hayenga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1804/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 7:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changes the o3 cpu to discard nops at decode. > > This stops nops from occupying scheduler/rob entries and commit/issue > bandwidth. > > > Diffs > ----- > > src/cpu/o3/commit_impl.hh 47591444a7c5 > src/cpu/o3/decode_impl.hh 47591444a7c5 > src/cpu/o3/iew.hh 47591444a7c5 > src/cpu/o3/iew_impl.hh 47591444a7c5 > > Diff: http://reviews.gem5.org/r/1804/diff/ > > > Testing > ------- > > A fast libquantum run. > > > Thanks, > > Mitch Hayenga > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
