----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1865/#review4519 -----------------------------------------------------------
There are some utility functions that would make this code slightly more readable. I'm just comparing to tournament.cc Otherwise, I think it's good. src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4247> It might be easier to do globalHistoryBits=ceilLog2(globalPredictorSize); src/cpu/pred/global.cc <http://reviews.gem5.org/r/1865/#comment4248> could do globalHistoryMask = mask(globalHistoryBits); (will need to include "base/bitfield.hh") - Erik Tomusk On July 15, 2013, 6:34 p.m., Taylor Lloyd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1865/ > ----------------------------------------------------------- > > (Updated July 15, 2013, 6:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds a global-global (gAG) branch predictor, used by specifying > the "global" predType. > From BranchPredictor, it uses the following variables for configuration: > - globalPredictorSize > - globalCtrBits > - globalHistoryBits > > As such, it may conflict with the ongoing effort to factor out the redundant > variable in the predictors. > > > Diffs > ----- > > src/cpu/pred/BranchPredictor.py 13ffc0066b76 > src/cpu/pred/SConscript 13ffc0066b76 > src/cpu/pred/bpred_unit.cc 13ffc0066b76 > src/cpu/pred/global.hh PRE-CREATION > src/cpu/pred/global.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1865/diff/ > > > Testing > ------- > > Prior to submission, this was tested by building build/ARM/gem5.debug, and > run against a subset of the SPEC CPU2006 benchmarks. Statistics generated > seem valid, and it caused no execution errors. > > > Thanks, > > Taylor Lloyd > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
