----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1987/#review4630 -----------------------------------------------------------
src/cpu/o3/cpu.cc <http://reviews.gem5.org/r/1987/#comment4380> Spacing around -, also extraneous parentheses around RegIndex src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4381> bool? src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4382> Somehow the parameters do not seem matched with the signature here. src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4383> const src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4384> const src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4385> const src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4386> const src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4387> const src/cpu/o3/free_list.hh <http://reviews.gem5.org/r/1987/#comment4388> const src/cpu/o3/free_list.cc <http://reviews.gem5.org/r/1987/#comment4389> Should not the cpu bit be the parent name, and should it not also contain the system bit etc? src/cpu/o3/regfile.cc <http://reviews.gem5.org/r/1987/#comment4390> I assume there is a good reason to not make these std::vectors. src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4391> freeList(NULL)? src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4392> const src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4393> const? src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4394> const src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4395> const src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4396> const src/cpu/o3/rename_map.hh <http://reviews.gem5.org/r/1987/#comment4397> const unsigned here and for numFreeEntries in the maps? src/cpu/o3/rename_map.cc <http://reviews.gem5.org/r/1987/#comment4398> Assert(freeList == NULL && map.empty()); Some minor bits and pieces - Andreas Hansson On Aug. 22, 2013, 12:40 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1987/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9850:65d5069b045e > --------------------------- > cpu/o3: clean up rename map and free list > > Restructured rename map and free list to clean up some > extraneous code and separate out common code that can > be reused across different register classes (int and fp > at this point). Both components now consist of a set > of Simple* objects that are stand-alone rename map & > free list for each class, plus a Unified* object that > presents a unified interface across all register > classes and then redirects accesses to the appropriate > Simple* object as needed. > > Moved free list initialization to PhysRegFile to better > isolate knowledge of physical register index mappings > to that class (and remove the need to pass a number > of parameters to the free list constructor). > > Causes a small change to these stats: > cpu.rename.int_rename_lookups > cpu.rename.fp_rename_lookups > because they are now categorized on a per-operand basis > rather than a per-instruction basis. > That is, an instruction with mixed fp/int/misc operand > types will have each operand categorized independently, > where previously the lookup was categorized based on > the instruction type. > > > Diffs > ----- > > src/cpu/o3/SConscript 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/cpu.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/cpu.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/cpu_policy.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/free_list.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/free_list.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/regfile.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/regfile.cc PRE-CREATION > src/cpu/o3/rename_impl.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/rename_map.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/rename_map.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > > Diff: http://reviews.gem5.org/r/1987/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
